Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update material-design-icons-iconfont version to match smk-cli #169

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

michaelpnelson
Copy link
Contributor

No description provided.

@michaelpnelson michaelpnelson requested a review from dgboss January 21, 2022 19:18
@michaelpnelson michaelpnelson self-assigned this Jan 21, 2022
@michaelpnelson
Copy link
Contributor Author

michaelpnelson commented Jan 21, 2022

I noticed that, after this change, package-lock.json is updated with a material-design-icons-iconfont version of 6.1.1. However smk-cli has a version of 6.1.0 in its package-lock.json. This is a minor change but means that some icons like "percent" are missing in smk-cli. When I deleted and rebuilt package-lock.json in smk-cli, the version was 6.1.1.

I could push a PR updating package-lock.json to smk-cli. But what do you think of changing package.json in both to specify 6.1.1 or greater (from "^6.1.0" to ">=6.1.1"), instead?

@dgboss
Copy link
Contributor

dgboss commented Jan 21, 2022

To keep dependencies in sync, my recommendation would be to lock the version at 6.1.1. Should should consider doing this for all dependencies that are common to both projects.

@michaelpnelson
Copy link
Contributor Author

michaelpnelson commented Jan 21, 2022

To keep dependencies in sync, my recommendation would be to lock the version at 6.1.1. Should should consider doing this for all dependencies that are common to both projects.

Sounds good. I'll update the following common dependencies to be versions only, here and for smk-cli:

  • "glob": "7.1.2"
  • "grunt": 1.4.1
  • "grunt-contrib-watch": "1.1.0"
  • "load-grunt-tasks": "4.0.0"
  • "material-design-icons-iconfont": "6.1.1"

UPDATE: Freezing "grunt" at 1.0.3 introduced 4 high priority audit warnings. Following the recommendation, it will be updated to 1.4.1.

@michaelpnelson
Copy link
Contributor Author

Related PR in smk-cli: bcgov/smk-cli#87

Copy link
Contributor

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants