Basemaps updated for new ESRI API #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates basemap code for ESRI basemaps to use the esri-leaflet-vector library and accommodate the use of an API key. Docs are updated, debug examples are updated to use a non-ESRI basemap, and SMK's version is incremented.
dgboss
suggested changes
Jul 20, 2022
| var lys = [] | ||
| lys.push( L.esri.basemapLayer( id, opt ) ) | ||
| function createBasemapEsri( apiId ) { | ||
| const apiKey = SMK.MAP[1].viewer.esriApiKey; |
There was a problem hiding this comment.
This lookup is unsafe, SMK.MAP[1] doesn't always exist. The '1' is the 'smk-id' and can be set by the user. See the SMK/Initialization docs for details.
There was a problem hiding this comment.
I'll reinstate the passing around of the "esriApiKey" value that we get from the smk object in the initialization method.
There was a problem hiding this comment.
You have a few other options for accessing the property:
- Object.getOwnPropertyNames
- Object.keys
- for const prop in my_object
dgboss
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates basemap code for ESRI basemaps to use the esri-leaflet-vector library and accommodate the use of an API key. Docs are updated, debug examples are updated to use a non-ESRI basemap, and SMK's version is incremented.