Add range and marker to Directions tool #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a UI control to direction options to allow input of a range as a positive integer. When a range value exists, the route planner now captures the point along the route where the range limit is met. The directions tool now shows a new marker at the range limit point.
|
Looks good overall. I like how modifying range updates the range marker without needing to run the route again. Marker dropshadow looks nice on the side it is on, but the marker white border doesn't have great contrast against the (current) light coloured basemap elsewhere. |
rustyjux
approved these changes
Mar 15, 2023
Comment on lines
+163
to
+172
| if (option.rangeKm > 0 && data.distance && option.rangeKm < data.distance) { | ||
| var distanceKm = 0; | ||
| for (var i = 0; i < data.route.length + 1; i += 1) { | ||
| distanceKm += turf.distance(data.route[i], data.route[i+1], {units: "kilometers"}); | ||
| if (distanceKm >= option.rangeKm) { | ||
| data.rangeLimit = data.route[i]; | ||
| break; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I like. Seems like performance is fair (~2 s), even for long routes with longer ranges (750 km)
| @@ -8,6 +8,8 @@ | |||
| <template slot="commands"> | |||
| </template> | |||
|
|
|||
| <enter-input v-bind:value="rangeKm" v-on:change="!busy && $$emit('change', {rangeKm: $event});">Range (km)</enter-input> | |||
There was a problem hiding this comment.
We had talked about a slider before, but entering a numerical value is quick and easy to be precise. Though slider would maybe be preferable on mobile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a UI control to direction options to allow input of a range as a positive integer. When a range value exists, the route planner now captures the point along the route where the range limit is met. The directions tool shows a new marker at the range limit point.