Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can override Other legend label #226

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

michaelpnelson
Copy link
Contributor

This adds an optional configuration parameter to vector/GeoJSON layers to replace "Other" as a legend label when conditional styling is used.

Documentation for the vector layer type is also updated.

This also increments SMK's version.

This adds an optional configuration parameter to vector/GeoJSON layers to replace "Other" as a legend label when conditional styling is used.

Documentation for the vector layer type is also updated.

This also increments SMK's version.
@michaelpnelson michaelpnelson self-assigned this Apr 28, 2023
Copy link
Contributor

@rustyjux rustyjux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature to have (alongside excluding other from the legend).
Looks like a clean and simple implementation. I haven't deployed locally but shouldn't be too much to test on this one.

@michaelpnelson michaelpnelson merged commit 014d843 into master Apr 28, 2023
@michaelpnelson michaelpnelson deleted the override_other_legend_label branch April 28, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants