API Endpoint upload files to s3 #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vice to handle upload to s3 and get files.
laidaoyu
reviewed
Sep 11, 2024
| [ProducesResponseType(typeof(Dictionary<string, List<string>>), (int)HttpStatusCode.OK)] | ||
| [ProducesResponseType(typeof(ErrorResponseModel), (int)HttpStatusCode.BadRequest)] | ||
| [SwaggerOperation(Tags = new[] { "Storage" })] | ||
| public async Task<IActionResult> UploadFilesToS3([FromQuery] DateTime? updatedBefore = null, [FromQuery] int? limit = null) |
There was a problem hiding this comment.
can set the parameter default value here:
[FromQuery] int? limit = 100
There was a problem hiding this comment.
sometime we don't pass limit into it, but we can change it later. this PR's purpose is to test upload from dev server.
|
looks good to me |
JacobWang-bc
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary:
I have the same variables in openshift