Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to generate strict VIN (exclusive characters I, O and Q) #421

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Add option to generate strict VIN (exclusive characters I, O and Q) #421

merged 1 commit into from
Jan 14, 2024

Conversation

skwasjer
Copy link
Contributor

@skwasjer skwasjer commented Apr 22, 2022

Adds an optional boolean to opt-in to generating a VIN using a more strict characterset.

In 1981, the National Highway Traffic Safety Administration of the United States standardized the format.[1] It required all on-road vehicles sold to contain a 17-character VIN, which does not include the letters O (o), I (i), and Q (q) (to avoid confusion with numerals 0, 1, and 9).

Fixes #449

@skwasjer
Copy link
Contributor Author

Any ETA on this? :)

ps: I could also remove the bool argument and just make this the default behavior if so desired.

There's also a bug I found whilst working on this, see #431

@bchavez bchavez merged commit 9a30883 into bchavez:master Jan 14, 2024
1 of 2 checks passed
bchavez added a commit that referenced this pull request Jan 14, 2024
@bchavez
Copy link
Owner

bchavez commented Jan 14, 2024

Hello. Thank you for the pull request.

Your changes are published in Bogus v35.4.0:

Thanks again for the help.
-Brian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bogus generates invalid VINs. VIN can't contain letters I, O and Q
2 participants