Resolve #156 Incompatible with Localstack #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed instead of only when the region is set to local. This will improve compatibility with other methods of mocking AWS services while maintaining compatbility with existing scripts since the host parameter was only used for this mode anyway.
bchew
reviewed
Dec 11, 2022
bchew
reviewed
Dec 11, 2022
There was a problem hiding this comment.
@mnuzzo-moxe thanks for the PR! Just have some minor wording change for the help usage and this would be good to merge 🙂
Updating help text per requested change.
|
Kudos, SonarCloud Quality Gate passed!
|
bchew
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue myself and was able to get the tool working by changing the behavior switch to key off of the use of the
hostparameter instead of thelocalregion. This improves compatibility with other methods of mocking AWS behavior which strictly mimic the actual regions without breaking compatibility with local scripts sincehostwas only used withlocalanyway.