Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: particle auth integration #175

Merged
merged 2 commits into from
May 30, 2023
Merged

feat: particle auth integration #175

merged 2 commits into from
May 30, 2023

Conversation

AmanRaj1608
Copy link
Contributor

@AmanRaj1608 AmanRaj1608 commented May 30, 2023

Description

Integration with Particle Web SDK. The particle auth will contain the ParticleAuthModule and BiconomyAccountModule which will help to do transactions

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Created a new react demo project and did few transactions.

Checklist:

1685440908723128.mp4
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AmanRaj1608 AmanRaj1608 changed the base branch from master to development May 30, 2023 14:01
Copy link
Contributor

@livingrockrises livingrockrises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@livingrockrises livingrockrises merged commit d1323d9 into development May 30, 2023
@AmanRaj1608 AmanRaj1608 deleted the particle-auth branch June 16, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants