Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pm rpc compatibility calcgaslimits #245

Merged

Conversation

livingrockrises
Copy link
Contributor

@livingrockrises livingrockrises commented Jul 31, 2023

Description

When you send pm_sponsorUserOperation to paymaster with calculateGasLimits = true, pm service is going to estimate on the EntryPoint from now by calling simulateHandleOp() which means we must pass dummy sig from the sdk also.

This also means gasLimits are not mandatory to be part of the request.

This change is about assuming less and covering more cases.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@livingrockrises
Copy link
Contributor Author

maybe maxFeePerGas and maxPriorityFeePerGas should still be expected and not be allowed to go undefined. Because paymaster doesn't return it even if it calculates internally gasfees to make a sign. (signature and fee quotes need maxFee and maxPriority)

@livingrockrises
Copy link
Contributor Author

needs to be checked SDK v3.1.0-alpha.0 with updates in the paymaster API and maybe update the docs with more info about sending flag and sending dummy sig values (as this version of sdk will delete it after estimations are done)

and SDK v3.2.0-alpha.0 will be working with updated paymaster API (since there is no versioning needed for this change)

@livingrockrises livingrockrises changed the base branch from master to development August 1, 2023 16:30
@livingrockrises livingrockrises merged commit b1ee103 into development Aug 1, 2023
@livingrockrises livingrockrises deleted the feat/pm-rpc-compatibility-calcgaslimits branch September 9, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants