Sma 42 modules specs #253
Merged
Sma 42 modules specs #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livingrockrises
requested review from
talhamalik883,
AmanRaj1608 and
tomarsachin2271
SMA-42 SA V2 - modules - Add validation modules specs
Define interfaces, classes and types for biconomy/modules package. |
livingrockrises
changed the base branch from
master
to
feat/modular-SA-V2-integration
packages/modules/src/utils/Utils.ts
Outdated
| return keccak256(enc) | ||
| } | ||
|
|
||
| export function packUserOp(op: UserOperation, forSignature = true): string { |
There was a problem hiding this comment.
why getUserOpHash and packUserOp methods are in modules utils?? They should be in SA utils.
There was a problem hiding this comment.
we use it here only. SA package makes read call in the SDK. I can move these to common package maybe
There was a problem hiding this comment.
yes common package makes sense.
tomarsachin2271
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: