fix: incorrect data merkleRoot length #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,8 @@ | |||
| import { Signer, ethers } from 'ethers' | |||
| import MerkleTree from 'merkletreejs' | |||
| import { getUserOpHash, NODE_CLIENT_URL } from '@biconomy/common' | |||
| import { hexConcat, arrayify, keccak256, hexZeroPad, defaultAbiCoder } from 'ethers/lib/utils' | |||
| import { hexConcat, arrayify, hexZeroPad, defaultAbiCoder } from 'ethers/lib/utils' | |||
| import { keccak256 } from 'ethereumjs-util' | |||
There was a problem hiding this comment.
do we need to use keccak256 from ethereumjs-util in other places too?
There was a problem hiding this comment.
Only for generating the merkle root this is required for now as the addLeaves needs buffer which we was generating and the length was incorrect
There was a problem hiding this comment.
in MultiChain Validator it would be fine? as we use keccak256 as arg in MerkleTree class
import {
keccak256,
arrayify,
defaultAbiCoder,
hexConcat,
hexZeroPad,
Bytes
} from 'ethers/lib/utils'
const merkleTree = new MerkleTree(leaves, keccak256, { sortPairs: true })
const multichainSignature = await this.signer.signMessage(arrayify(merkleTree.getHexRoot()))
Logger.log('merkle root ', merkleTree.getHexRoot())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue reported by rage trade.
ethers/lib/utilskeccak256 returns the 32 bytes output on getHexRoot.