Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init with nonce options for account V2 #285

Merged

Conversation

livingrockrises
Copy link
Contributor

Description

2D nonce support + Manual nonce override support in case anyone needs it!

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@linear
Copy link

linear bot commented Sep 9, 2023

SMA-67 Design for 2D Nonce Support

added this page here

https://www.notion.so/biconomy/2D-nonces-in-SA-7523daf610114fd7a6d4d4cf147fe015

after we all agree, can start the implementation and supporting it in the implementation contract and the SDK.

@livingrockrises livingrockrises merged commit 757a0ad into feat/modular-SA-V2-integration Sep 11, 2023
@AmanRaj1608 AmanRaj1608 deleted the SMA-67-2D-nonce-account-V2 branch September 29, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants