add simulation type param #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modular Account V2 Integration
| simulationType?: SimulationType; | ||
| }; | ||
|
|
||
| export type SimulationType = "validation" | "validation_and_execution"; |
There was a problem hiding this comment.
can we make this proper enums? and options as all uppercase
There was a problem hiding this comment.
Want to avoid the enums as it makes the code large, client have to import the enum from types and then pass it EnumName.Value, meanwhile this will be autofill in string. The values are also not that large, just two possible cases.
livingrockrises
approved these changes
Sep 27, 2023
Latency Optimisations for buildUserOp
arcticfloyd1984
approved these changes
Sep 28, 2023
livingrockrises
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone wants to have this call data check on their end for every transaction we have enabled more parameters in our eth_sendUserOperation to pass in a simulation_type an example curl for this: https://gist.github.com/arcticfloyd1984/26efb6099efc651d2cf064340c67c6db.