-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/devx 336 abstract paymaster #334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livingrockrises
requested review from
ankurdubey521,
AmanRaj1608 and
livingrockrises
and removed request for
ankurdubey521
December 5, 2023 09:55
packages/account/tests/SmartAccountV2-Abstract-Paymaster.local.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
VGabriel45
commented
Dec 6, 2023
livingrockrises
approved these changes
Dec 6, 2023
AmanRaj1608
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue: # (DEVX-336)
Change Type
Checklist
Additional Information
The context of this PR is to optimize developer experience of the SDK.
This PR will remove the need for the user/developer to create the Paymaster instance and then provide it to the "create()" method config. Paymaster can be easily setup by only providing an "apiKey" in the config.
Old method of creating instance and providing it to the config by the user/developer is still available for compatibility reasons.