Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/devx 336 abstract paymaster #334

Merged
merged 5 commits into from
Dec 11, 2023

Conversation

VGabriel45
Copy link
Collaborator

Summary

Related Issue: # (DEVX-336)

Change Type

  • Bug Fix
  • Refactor
  • New Feature
  • Breaking Change
  • Documentation Update
  • Performance Improvement
  • Other

Checklist

  • My code follows this project's style guidelines
  • I've reviewed my own code
  • I've added comments for any hard-to-understand areas
  • I've updated the documentation if necessary
  • My changes generate no new warnings
  • I've added tests that prove my fix is effective or my feature works
  • All unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Information

The context of this PR is to optimize developer experience of the SDK.
This PR will remove the need for the user/developer to create the Paymaster instance and then provide it to the "create()" method config. Paymaster can be easily setup by only providing an "apiKey" in the config.

Old method of creating instance and providing it to the config by the user/developer is still available for compatibility reasons.

Copy link

linear bot commented Dec 4, 2023

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@livingrockrises livingrockrises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@livingrockrises livingrockrises merged commit c1c4041 into develop Dec 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants