Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/devx 349 wallet client signer support #339

Merged
merged 7 commits into from
Dec 21, 2023
Merged

Feat/devx 349 wallet client signer support #339

merged 7 commits into from
Dec 21, 2023

Conversation

VGabriel45
Copy link
Collaborator

Summary

Added WalletClientSigner support + tests

Related Issue: #DEVX-349

Change Type

  • Bug Fix
  • Refactor
  • New Feature
  • Breaking Change
  • Documentation Update
  • Performance Improvement
  • Other

Checklist

  • My code follows this project's style guidelines
  • I've reviewed my own code
  • I've added comments for any hard-to-understand areas
  • I've updated the documentation if necessary
  • My changes generate no new warnings
  • I've added tests that prove my fix is effective or my feature works
  • All unit tests pass locally with my changes
  • Any dependent changes have been merged and published

@linear Linear
Copy link

linear bot commented Dec 15, 2023

DEVX-349 WalletClientSigner support in the sdk

livingrockrises
livingrockrises reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@livingrockrises livingrockrises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review 1 done

@livingrockrises
Copy link
Contributor

I'd say every time try couple of backend node scripts with your local build.

AmanRaj1608
AmanRaj1608 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@AmanRaj1608 AmanRaj1608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

livingrockrises
livingrockrises approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@livingrockrises livingrockrises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@livingrockrises livingrockrises merged commit 510dc95 into develop Dec 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepegler joepegler joepegler left review comments

@livingrockrises livingrockrises livingrockrises approved these changes

@AmanRaj1608 AmanRaj1608 AmanRaj1608 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VGabriel45 @livingrockrises @joepegler @AmanRaj1608 @GabiDev45