chore: improve session dx #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
joepegler
force-pushed
the
feat/use_session_dx_tweak
branch
from
e08367e to
6b440a5
Compare
AmanRaj1608
reviewed
May 23, 2024
| } else { | ||
| if (!data) { | ||
| resolve(null) | ||
| nodeFs.readFile( |
There was a problem hiding this comment.
This will only work on backend, which is expected as this is for file storage. Is there any possibility of FE getting error because one of the files is using node-fs?
There was a problem hiding this comment.
Not unless the dev explicitly does something silly. By default localStorage only is used in the browser.
AmanRaj1608
approved these changes
May 23, 2024
joepegler
force-pushed
the
feat/use_session_dx_tweak
branch
from
1691424 to
fe38ad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstracts away storageClient + sessionIDInfo.
Users now only need to keep the users smartAccountAddress when returning to use a session
PR-Codex overview
The focus of this PR is to update version to 4.4.3, enhance session storage abstraction, and improve testing workflows.
Detailed summary