chore: release v4.5.6 #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: add test concurrency using nonceOptions (#506) --------- Co-authored-by: GabiDev <gv@popoo.io> Co-authored-by: Joe Pegler <joepegler123@gmail.com>
* chore: support erc20 payment session
* chore: release v4.4.5
joepegler
requested review from
VGabriel45 and
livingrockrises
and removed request for
VGabriel45
chore: skip transfer tests
* fix: remove file storage (#515)
joepegler
requested review from
VGabriel45 and
AmanRaj1608
and removed request for
VGabriel45
|
Just one small thing, PR title says 4.5.5 release but it should be 4.4.6 |
VGabriel45
reviewed
Jun 6, 2024
| * @param chain - The chain object | ||
| * @returns {@link SupportedSigner} - A signer object that can be used to sign transactions | ||
| */ | ||
| export const toSupportedSigner = ( |
There was a problem hiding this comment.
Curious to know where would this be useful ? We could already pass private key accounts without this function
There was a problem hiding this comment.
TBH I'm not 100% certain, but from what I've seen the typical way our sessions are used is: a dapp will not use sessionStorageClient in the backend, instead saving private keys to a db or similar, and then reconstruct the signer from the relevant private key in the backend at run time on request. I thought this would be useful helper to dapps with such a setup, and I might document it in a 'sessions in the backend' tutorial or similar moving forward
livingrockrises
approved these changes
Jun 6, 2024
VGabriel45
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR updates the Biconomy SDK to version 4.4.6, introducing changes related to session storage, token payment, and smart accounts.
Detailed summary
SessionStorageClientto a separate package