Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: signTypedData draft #519

Merged
merged 1 commit into from
Jun 17, 2024
Merged

feat: signTypedData draft #519

merged 1 commit into from
Jun 17, 2024

Conversation

VGabriel45
Copy link
Collaborator

@VGabriel45 VGabriel45 commented Jun 13, 2024

PR-Codex overview

The focus of this PR is to implement the signTypedData method in BaseSmartContractAccount and add MAGIC_BYTES constant in Utils.ts.

Detailed summary

  • Implemented signTypedData method in BaseSmartContractAccount
  • Added MAGIC_BYTES constant in Utils.ts
  • Added test for signing typed data in read.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

github-actions bot commented Jun 13, 2024

size-limit report 📦

Path Size
core (esm) 54.13 KB (-0.07% 🔽)
core (cjs) 59.26 KB (-0.11% 🔽)
account (tree-shaking) 51.84 KB (-0.03% 🔽)
bundler (tree-shaking) 2.63 KB (0%)
paymaster (tree-shaking) 2.33 KB (0%)
modules (tree-shaking) 40.17 KB (0%)

@VGabriel45 VGabriel45 marked this pull request as ready for review June 14, 2024 14:54
@VGabriel45 VGabriel45 merged commit f7d84ef into develop Jun 17, 2024
10 of 11 checks passed
VGabriel45 added a commit that referenced this pull request Jul 2, 2024
* ci: fix (#517)

chore: cont

* chore: add hooks to readme

chore: readme

* feat: signTypedData draft (#519)

Co-authored-by: GabiDev <gv@popoo.io>

* fix: rpc (#522)

* fix: rpcUrl

* feat: skip chain checks flag (#526)

Co-authored-by: GabiDev <gv@popoo.io>

* fix: replace broken doc links (#525)

fix: replace broken doc links (#525)

* feat: revoke sessions (#528)

* feat: revoke sessions

* feat: added ts doc

* fix: lint

* fix: test cases

* fix: remove duplicate test

---------

Co-authored-by: GabiDev <gv@popoo.io>

* chore: v.4.5.0 (#529)

* chore: v.4.5.0

* fix: fix changeset

---------

Co-authored-by: GabiDev <gv@popoo.io>

---------

Co-authored-by: joepegler <joepegler123@gmail.com>
Co-authored-by: GabiDev <gv@popoo.io>
Co-authored-by: Veljko Vranić <byblos94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants