fix: remove sign typed data #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
| this.isAccountDeployed(), | ||
| this.signTypedData(params) | ||
| ]) | ||
| throw new Error("signTypedDataWith6492 not supported") |
There was a problem hiding this comment.
why is this commented out?
should we remove this method all together since it is custom name
livingrockrises
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing signTypedData as Biconomy Smart Account V2 is not compatible with ERC 712.
The assumption made at integration time of this feature was incorrect and can be confusing if not removed.
PR-Codex overview
This PR updates the codebase to remove the functionality of signing typed data in smart accounts and adds error handling for unsupported operations.
Detailed summary