Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/5irechain #679

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Fix/5irechain #679

merged 2 commits into from
Aug 29, 2024

Conversation

TheDivic
Copy link
Collaborator

📖 Context

Type of change

  • Non-breaking change (backwards compatible)

Why are we doing this?

  • User ops on testnet were failing because of callGasLimit was too high
  • Transactions on mainnet were failing because the relayerFundingAmount was too low
  • The retry code couldn't recognize the error from the previous step because of an unconventional error message, added it to the config.

What did we do?

  • Disabled state overrides, solved the callGasLimit problem
  • Added a new error message to the config
  • Increased the funding amount from 0.01 to 0.1

How Has This Been Tested?

@TheDivic
feat(integrations): ✨ 5irechain mainnet integration
e691f38 
Currently tests don't pass because it fails with "Nonce error" waiting for the 5irechain team to get back to us
@TheDivic
fix(integrations): 🐛 Fix 5irechain integration parameters
1c85961 
Increase the relayer funding amount, disable state overrides & gracefully handle a new (weird) RPC error response
@TheDivic TheDivic added the ⛓️ Chain Integration Label for all chain integration related tasks label Aug 29, 2024
@TheDivic TheDivic self-assigned this Aug 29, 2024
@TheDivic TheDivic merged commit 174cbd1 into master Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcticfloyd1984 arcticfloyd1984 arcticfloyd1984 approved these changes

@veljkovranic veljkovranic Awaiting requested review from veljkovranic

Assignees

@TheDivic TheDivic

Labels
⛓️ Chain Integration Label for all chain integration related tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheDivic @arcticfloyd1984