Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback to 9 oct #719

Merged
merged 1 commit into from
Oct 14, 2024
Merged

rollback to 9 oct #719

merged 1 commit into from
Oct 14, 2024

Conversation

TakGN
Copy link
Collaborator

@TakGN TakGN commented Oct 14, 2024

📖 Context

merge and deploy in case we want to rollback.

  • Non-breaking change (backwards compatible)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Why are we doing this?

  • Customer X complained that PVG was too high on Y network so we discovered that ...
  • The service was crashing on production because of ...
  • Person A from team B asked me to do this so they can ...

Related issues:

  • link to issue / ticket

What did we do?

  • We changed the PVG formula to use ...
  • Added a try/catch clause to prevent crashes when ...

How Has This Been Tested?

  • Tested this manually by sending a user op on the Y network and ...
  • Added unit tests that check if ...

👀 How do I review this?

  • Check the parameters in file ... and compare them to ...
  • To test this you first need to checkout this branch and run the following command ...

@veljkovranic veljkovranic merged commit 0320f3e into master Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants