Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/batched session router skm verification algorithm #161

Merged

Conversation

filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Oct 26, 2023

Summary

Changed the way Batched Session Router checks the appropriate Session Key Manager was provided in the signature.
Now BSR checks that the SKM address provided is enabled for this SA using isModuleEnabled.

Change Type

  • Bug Fix

Checklist

  • My code follows this project's style guidelines
  • I've reviewed my own code
  • I've added comments for any hard-to-understand areas
  • I've updated the documentation if necessary
  • My changes generate no new warnings
  • I've added tests that prove my fix is effective or my feature works
  • All unit tests pass locally with my changes
  • Any dependent changes have been merged and published

@filmakarov filmakarov merged commit 13f90c5 into develop Oct 26, 2023
2 checks passed
@filmakarov filmakarov deleted the features/Batched-Session-Router-SKM-verification-algorithm branch October 26, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants