Adding --extension option, allowing override of defaults.
#340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Node.js experimental ESM loaders to have Node process `.svelte` files, and now I can run code coverage on them too. Modified `--all` option to check file extensions against `extension` list instead of a hard-coded list. Updated links for default lists in README for `--exclude` and `--extension`. Tests are passing. I did not add new tests, as that would require either changing, or adding, a test runner to use ESM loaders. As the changes here are simple, I thought it might be overkill. But let me know what you think. thanks!
|
Oh wow, this is a duplicate of #331 haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
--extensionoption, allowing override of defaults.I'm using experimental ESM loaders to have Node.js process
.sveltefiles, and now I can run code coverage on them too.Modified
--alloption to check file extensions againstextensionlistinstead of a hard-coded list.
Updated links for default lists in README for
--excludeand--extension.Tests are passing.
I did not add new tests, as that would require either changing, or adding, a
test runner to use ESM loaders. As the changes here are simple, I thought it
might be overkill. But let me know what you think.
thanks!
Checklist
npm test, tests passingnpm run test:snap(to update the snapshot)