-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent crash when v8 incorrectly merges static_initializer's #2
Conversation
@AriPerkkio @bcoe would it be possible to merge this PR? |
I'd also greatly appreciate it if this MR could be merged |
If you are running into this issue, try upgrading your Node to latest version. Looks like there has been some fixes related to V8 coverage reporting. |
Thanks for the heads up! Would it be possible to merge this MR nonetheless? I am working on a large project on Node 18, in which it's very costly to upgrade to Node 20. |
I've tested on Node 20.12.2 and it still has the same issue. Node 22.1.0 does not have this issue indeed! I think a lot of people will still be on an LTS version, so I think it will be helpful if this MR can be merged. |
node 22 again
This reverts commit 9b020a3.
I would appreciate it if you would merge the PR |
Should fix test coverage reports (Source: bcoe/v8-coverage#2)
Fixes vitest-dev/vitest#5329.
Reproduction: