Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several segmentation faults with leveldb bindings #868

Merged
merged 2 commits into from
Feb 18, 2020

Conversation

braydonf
Copy link
Contributor

@braydonf braydonf commented Oct 8, 2019

See bcoin-org/bdb#8 and bcoin-org/bdb#7 for details.

@braydonf braydonf added the waiting for dependency Waiting for a dependency update. label Oct 8, 2019
@tuxcanfly
Copy link
Member

Tested OK. Did not experience any segfault or crash when testing fullnode mainnet sync against this branch.

@tuxcanfly tuxcanfly self-requested a review November 6, 2019 05:34
Copy link
Member

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@braydonf braydonf added this to the 2.0.0 milestone Jan 6, 2020
@codecov-io

This comment has been minimized.

@braydonf braydonf removed the waiting for dependency Waiting for a dependency update. label Feb 18, 2020
braydonf added a commit that referenced this pull request Feb 18, 2020
Fix several segmentation faults with leveldb bindings
@braydonf braydonf merged commit 723b2e1 into bcoin-org:master Feb 18, 2020
@braydonf braydonf deleted the update-bdb branch February 18, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants