Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI config #62

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Update CI config #62

merged 1 commit into from
Oct 22, 2021

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Oct 5, 2021

  • specify FORCE_COLOR:2 so that we get colored output
  • switch to the actions tags

BTW it seems the actions don't fire on this repo from forks, so here is the run from my fork: https://github.com/XhmikosR/npm-run-all2/runs/3799626983

PS1. it seems tests break with Node.js 16 which is using npm 7.x. They changed how the npm_config stuff works. Personally I'm using a config key in my package.json and that works on both npm 6 and 7.
PS2. this will probably conflict with #61, ping me to rebase when needed
PS3. the engines package.json property is using >=10 but Node.js 10 isn't tested on CI

@XhmikosR XhmikosR marked this pull request as draft October 5, 2021 04:55
@XhmikosR XhmikosR changed the title CI: switch to the actions tags and add Node.js 16 Update CI config Oct 5, 2021
@XhmikosR XhmikosR marked this pull request as ready for review October 5, 2021 05:44
Copy link
Owner

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Colored output is nice. I'm going to make a few more tweaks.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 8, 2021

I pushed a indentation fix and fail-fast: false too. Lint should only run once but that's for another time since currently we can't have caching due to no lock file.

The non-whitespace diff is clearer: https://github.com/bcomnes/npm-run-all2/pull/62/files?w=1

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #62 (0c335f4) into master (8e72b7c) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 0c335f4 differs from pull request most recent head 3d30f33. Consider uploading reports for the commit 3d30f33 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   92.66%   92.56%   -0.10%     
==========================================
  Files          23       22       -1     
  Lines         477      471       -6     
==========================================
- Hits          442      436       -6     
  Misses         35       35              
Flag Coverage Δ
ubuntu-latest-12 92.56% <ø> (ø)
ubuntu-latest-14 92.56% <ø> (ø)
windows-latest-12 ?
windows-latest-14 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/spawn-win32.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8356ed...3d30f33. Read the comment docs.

* specify `FORCE_COLOR:2` so that we get colored output
* specify `fail-fast: false`
* switch to the actions tags when possible
* reindent
@bcomnes
Copy link
Owner

bcomnes commented Oct 22, 2021

Sorry to be so slow on these, in the middle of a move and just started a new job.

@bcomnes bcomnes merged commit 3fe3dcc into bcomnes:master Oct 22, 2021
@XhmikosR XhmikosR deleted the ci branch October 22, 2021 17:25
@XhmikosR
Copy link
Contributor Author

No worries, take care!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants