Update tests targets to Swift 4.2 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28 +/- ##
========================================
Coverage 94.71% 94.71%
========================================
Files 12 12
Lines 284 284
========================================
Hits 269 269
Misses 15 15 |
|
Thanks for the pull request. Inhibiting warnings for the Quick target sounds like a good solution. |
At this time the Quick testing framework hasn't yet been updated to Swift 4.2. This causing some compilation warnings to be generated by the compiler. While discussing bcylin#26, it was decided to solve this issue by inhibiting warnings generated by the Quick pod for tests target.
bcylin
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #26 by updating all tests targets to Swift 4.2.
There's still one small issue that needs to be addressed and I would greatly appreciate @bcylin input on it.
It seems like Quick and Nimble have yet to be updated for Swift 4.2. This generates the following warning.
Do you have any preferred way to handle this? Here are some of the options: