-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 5 migration #38
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #38 +/- ##
==========================================
- Coverage 95.37% 95.1% -0.28%
==========================================
Files 14 14
Lines 281 347 +66
==========================================
+ Hits 268 330 +62
- Misses 13 17 +4
|
Codecov Report
@@ Coverage Diff @@
## develop #38 +/- ##
==========================================
- Coverage 95.37% 95.1% -0.28%
==========================================
Files 14 14
Lines 281 347 +66
==========================================
+ Hits 268 330 +62
- Misses 13 17 +4
|
Seems like the only untested code is the addition of |
@bcylin I could use your help in resolving these errors when building the docs:
|
Hi @getaaron, thank you very much for this pull request! No worries about the untested The
|
e161b7b
to
0045694
Compare
Nice, you beat me to it @bcylin! What happened with index vs. firstIndex? |
I've still got some issue with What's about index vs. firstIndex? Is it 369e652#diff-457d78d98b22052d0d7662f3f9506a44? |
All tests pass.
English
localization toen
.default
for potential future unknownUITableViewCellStyle
s using Swift 5's new@unknown default
for enums imported from C-based languagesOut of scope: