Fix collapsing html email preview #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, the css of an email may cause the `document.body.clientHeight` to report 0, which collapses the email preview iframe. Using `contentWindow.outerHeight` seems to work around this issue.
paulcsmith
approved these changes
Feb 27, 2018
germsvel
pushed a commit
that referenced
this pull request
Feb 15, 2021
What changed? ---------------- This commit uses the `screen.availHeight` property as a fallback to how we currently set the iframe's height. See [screen docs]. [Screen docs]: https://developer.mozilla.org/en-US/docs/Web/API/Screen Why? ------- As part of the Wallaby feature test I've needed to read an email, but I could only get iframe element using `Wallaby.Query.css("iframe", visible: false)` because the height of the element is 0. I've tried this in multiple versions of Chrome and chromedriver. Also, I've only been able to experience this in headless Chrome in macOS. I wasn't having this issue with Wallaby option headless: false nor on a CI instance running Ubuntu. Related to #350 and #351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the css of an email may cause the
document.body.clientHeightto report 0, which collapses the email preview iframe. UsingcontentWindow.outerHeightseems to work aroundthis issue. Fixes #350.