-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add refute_email_delivered_with helper, tests #484
Merged
maymillerricci
merged 4 commits into
beam-community:master
from
mtarnovan:add_refute_email_delivered_with
Oct 25, 2019
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -203,6 +203,41 @@ defmodule Bamboo.Test do | |
end | ||
end | ||
|
||
@doc """ | ||
Check that no email was sent with the given parameters | ||
|
||
Similarly to `assert_email_delivered_with`, the assertion waits up to 100ms before | ||
failing. Note that you need to send the email again if you want to make other | ||
assertions after this, as this will receive the `{:delivered_email, email}` message. | ||
|
||
## Examples | ||
|
||
Bamboo.Email.new_email(subject: "something") |> MyApp.Mailer.deliver | ||
refute_email_delivered_with(subject: "something else") # Will pass | ||
|
||
email = Bamboo.Email.new_email(subject: "something") |> MyApp.Mailer.deliver | ||
refute_email_delivered_with(subject: ~r/some/) # Will fail | ||
""" | ||
defmacro refute_email_delivered_with(email_params) do | ||
quote bind_quoted: [email_params: email_params] do | ||
import ExUnit.Assertions | ||
|
||
received_email_params = | ||
receive do | ||
{:delivered_email, email} -> Map.from_struct(email) | ||
after | ||
100 -> [] | ||
end | ||
|
||
if is_nil(received_email_params) do | ||
refute false | ||
else | ||
refute Enum.any?(email_params, fn {k, v} -> do_match(received_email_params[k], v) end), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe this should be |
||
Bamboo.Test.flunk_attributes_match(email_params, received_email_params) | ||
end | ||
end | ||
end | ||
|
||
@doc false | ||
def do_match(value1, value2 = %Regex{}) do | ||
Regex.match?(value2, value1) | ||
|
@@ -263,6 +298,21 @@ defmodule Bamboo.Test do | |
""" | ||
end | ||
|
||
@doc false | ||
def flunk_attributes_match(params_given, params_received) do | ||
""" | ||
The parameters given match. | ||
|
||
Parameters given: | ||
|
||
#{inspect(params_given)} | ||
|
||
Email received: | ||
|
||
#{inspect(params_received)} | ||
""" | ||
end | ||
|
||
defp delivered_emails do | ||
{:messages, messages} = Process.info(self(), :messages) | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!! Thoughts on adding some documentation for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
249ce54