Organize Bamboo's TestAdapter test file #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What changed? ============ I wanted to get a better understanding of Bamboo's test helpers to improve them, but it was difficult to find out how we were testing them in the `test_adapter_test.exs` . They all seemed interspersed without any structure. So this commit organizes them by function they are testing. We also try to use `assert_raise` were possible to simplify the assertions, while continuing to match the error and the error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I wanted to get a better understanding of Bamboo's test helpers to improve them, but it was difficult to find out how we were testing them in the
test_adapter_test.exs.They all seemed interspersed without any structure. So this commit organizes them by function they are testing. We also try to use
assert_raisewere possible to simplify the assertions, while continuing to match the error and the error message.