Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve CLI progress percentage display #27

Merged
merged 1 commit into from
Jun 21, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion bin/nwget
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ nwget https://raw.github.com/Fyrd/caniuse/master/data.json -O /tmp/data.json

var wget = require('../lib/wget');
var path = require('path');
var readline = require('readline');

var args = require('minimist')(process.argv);
var url = args._[2]
Expand All @@ -32,11 +33,18 @@ if (!output) return console.error('The second argument must be a file path for t
var download = wget.download(url, path.resolve(output));

download.on('error', function(err) {
process.stdout.write('\n');
console.error(err);
});
download.on('end', function(output) {
readline.cursorTo(process.stdout, 0);
console.log(output);
});
download.on('progress', function(progress) {
console.log(progress);
printProgressPercent(progress);
});

function printProgressPercent(progress) {
readline.cursorTo(process.stdout, 0);
process.stdout.write('Downloading... ' + Math.round(progress * 100) + '%');
}