Unnecessary spaces in PHP code

[mrpavlikov]

I have some html file with php insertions:

<h1 class="content-page-header"><?=$view['name']; ?></h1>

After beautifying I use to have this:

<h1 class="content-page-header">
    <?=$view[ 'name']; ?>
</h1>

See that space right after [.

Also code like this:

<?= $view['content'][0]['descr']; ?>

becomes:

<?=$ view[ 'content'][0][ 'descr']; ?>

and ofc breaks syntax.

I seem to be unable to find the way to solve this. Is there any?

[evocateur]

There probably is, but I'm not very familiar with the beautify-html script. The limitations of a non-parsing tokenizer really make handling templating syntax hairy.

[dboune]

I believe the best option for this case, and other similar tickets here, is to allow beautify-html to leave the contents of <?= ... ?> and <?php ... ?> tags unformatted. I'm sure there may be other tags that could benefit from the same treatment. So far I have not found any existing setting sufficient to remedy this or other similar issues.

Should someone come along with a PR to handle PHP, wonderful, but until then the ability to ignore it would be extremely useful.

[bitwiseman]

Agreed. Go for it!

[dboune]

👏 Thank you!

[esetnik]

This is still happening for unclosed single quotes.

Example:

<a href='' onclick='doIt("<?php echo str_replace("'", "\\ ", $var); ?>  "); '>
                            Test
                        </a>
                
<?php include_once $_SERVER['DOCUMENT_ROOT'] . "/shared/helpModal.php";  ?>

Output:

<a href='' onclick='doIt("<?php echo str_replace("' ", "\\ ", $var); ?>  "); '>
                            Test
                        </a>
                
<?php include_once $_SERVER['DOCUMENT_ROOT '] . "/shared/helpModal.php";  ?>

Note that $_SERVER['DOCUMENT_ROOT '] will be broken after formatting.

[bitwiseman]

@esetnik
Wow, that is bad. Please open a new issue.