-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack #1149
Webpack #1149
Conversation
e32e088
to
dc31c89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
||
install: | ||
- rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm && (cd ~/.nvm && git checkout `git describe --abbrev=0 --tags`) && source ~/.nvm/nvm.sh && nvm install $TRAVIS_NODE_VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this incantation necessary? I thought Travis already used nvm
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evocateur - only on node projects. This is python project that happens to run node. Travis would default to node 0.12. This was fine until this change - webpack requires a newer version of node to work. Thus incantation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, I forgot about that.
My two cents
everything else looks pretty straight forward - and the modularization will definitely provide real value. I'm sorry to say I can't spend any time testing as I'm knee deep in a couple side projects and haven't used any beautifiers in some time (my employer's CI process is laughable so I've just gotten used to 'Laissez-faire' looking code). Edit: As always, I respect the time you put into this library @bitwiseman. You do a solid job. |
Thanks for taking a look. I appreciate the time you've spent on the project and your continued participation. |
@evocateur @olsonpm |
@bitwiseman Sorry I haven't provided any input. Been pretty busy. May get to have a look this week. 🤞 |
4ccb871
to
9af2a50
Compare
df680f2
to
8e606d8
Compare
a19ea6a
to
d0d0f43
Compare
@evocateur @einars @HookyQR @olsonpm @mmsqe
Hello all. This is an early preview of my plan to begin moving to a module based structure for this project. I've like to hear any feedback you have, but there's no hurry, there's still quite a way to go before it lands. If nothing else, I need to mirror the modularization in the Python implementation.
There are two conflicting requirements for this change:
I think I've achieved that. I could use any help you can provide
When this goes in, I will let it bake and make further non-breaking internal changes and clean up.
As part of this change I change the css beautifier to use the same
Output
class as the js beautifier.I think this and various follow up refactorings will unblock a number of improvements, such as parsing of html and css, fewer bugs, and eventually a 2.0 release the drops a bunch of legacy hacks.