Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undindent-chained-methods option. Resolves #482 #1240

Merged
merged 5 commits into from
Sep 7, 2017
Merged

undindent-chained-methods option. Resolves #482 #1240

merged 5 commits into from
Sep 7, 2017

Conversation

aecepoglu
Copy link
Contributor

No description provided.

@aecepoglu aecepoglu mentioned this pull request Sep 6, 2017
Closed
@aecepoglu
Copy link
Contributor Author

I didn't test the unindent-chained-methods option in combinations with other options. Also I didn't test the python side manually.

Let me know if there is anything missing

@brandondrew
Copy link

👍 Hallelujah!

bitwiseman
bitwiseman approved these changes Sep 7, 2017
View reviewed changes
Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Surprised "-u" not already taken.

@bitwiseman bitwiseman merged commit ed61dc1 into beautifier:master Sep 7, 2017
@aecepoglu
Copy link
Contributor Author

aecepoglu commented Sep 7, 2017 •
edited
Loading

I was going to squash the commits together. I wasn't sure whether github did that automatically or not.

Anyway, I'm glad this is finally over after 18 months of delay

@pietrovismara
Copy link

@aecepoglu Thank you so much man, now it's my turn to go to atom-beautify repo and press them to update js-beautify.

@pietrovismara pietrovismara mentioned this pull request Sep 7, 2017
Closed
@bitwiseman
Copy link
Member

@aecepoglu - I could do the squash as part of merging the PR, but I just didn't. 😄 No big deal.

@bitwiseman
Copy link
Member

@aecepoglu - also, I need to release the new version before you can do that.

@bitwiseman bitwiseman modified the milestone: v1.7.0 Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman bitwiseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@aecepoglu @brandondrew @pietrovismara @bitwiseman