Allow <style> and <script> tags to be unformatted
#494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good but needs some tests. Please add those and we'll merge. |
|
Can you give me some pointers on how to do that? |
|
There's a tests file that runs the beautifier over various inputs. See 219a44e for example. |
|
@bitwiseman I've added the tests. Please check if it's OK. |
| @@ -1978,6 +1978,19 @@ function run_beautifier_tests(test_obj, Urlencoded, js_beautify, html_beautify, | |||
| opts.preserve_newlines = false; | |||
| bth('<div>\n\tfoo\n</div>', '<div>foo</div>'); | |||
|
|
|||
| opts.unformatted = ['script', 'style']; | |||
There was a problem hiding this comment.
You'll need to save opt.unformatted and restore it after you're done. You might also put it closer to https://github.com/JoseGoncalves/js-beautify/blob/master/js/test/beautify-tests.js#L1790 , since those are also script tag tests.
Other than that, looks good.
|
Addressed your comments with a2f7f75. |
|
Okay, last thing - please rebase your commits in this PR into a single commit. |
|
Done! Hope it's OK now. |
bitwiseman
added a commit
that referenced
this pull request
Sep 15, 2014
Allow <style> and <script> tags to be unformatted
bitwiseman
changed the title
<style> and <script> tags to be unformatted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow do not format 'script' and 'style' tags if they are set in the "unformatted" property from the configuration object.