Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brace_style "none" option + tests for javascript, then cleanup all brace_style tests #554

Merged
merged 9 commits into from
Oct 6, 2014

Commits on Oct 5, 2014

  1. Configuration menu
    Copy the full SHA
    4bcd110 View commit details
    Browse the repository at this point in the history
  2. Clean up tests for the existing brace_style options

    - Move several tests not involving brace positions out of the brace position testing
      section, and eliminate duplication
    - Ensure parallel tests exist for all 3 brace styles
    - Add comments to clarify the sections are testing brace positions
    - Move copy-pasted, commented out test up to opening brace position tests comment,
      and add note to update tests correctly if the case is ever supported.
    c32hedge committed Oct 5, 2014
    Configuration menu
    Copy the full SHA
    163bc23 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    140b18e View commit details
    Browse the repository at this point in the history
  4. Remove duplicate tests

    Each removed test was an exact duplicate of the test 5 lines before it
    c32hedge committed Oct 5, 2014
    Configuration menu
    Copy the full SHA
    7d0a19c View commit details
    Browse the repository at this point in the history
  5. Remove bt_braces function that is never used

    looks very similar to what I plan to implement in my next commit
    c32hedge committed Oct 5, 2014
    Configuration menu
    Copy the full SHA
    e553a8b View commit details
    Browse the repository at this point in the history
  6. Refactor brace position tests to eliminate copy-pasting

    Abstracts out the opening and closing whitespace before opening braces
    and before closing braces, respectively, so that the tests are all written in
    one place instead of 4 huge blocks, 1 for each brace style.
    c32hedge committed Oct 5, 2014
    Configuration menu
    Copy the full SHA
    4524383 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2014

  1. Configuration menu
    Copy the full SHA
    0fa529f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f97d0d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    670f44c View commit details
    Browse the repository at this point in the history