-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brace_style "none" option + tests for javascript, then cleanup all brace_style tests #554
Merged
bitwiseman
merged 9 commits into
beautifier:master
from
c32hedge:c32hedge/brace-style-none
Oct 6, 2014
Merged
Add brace_style "none" option + tests for javascript, then cleanup all brace_style tests #554
bitwiseman
merged 9 commits into
beautifier:master
from
c32hedge:c32hedge/brace-style-none
Oct 6, 2014
Commits on Oct 5, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 4bcd110 - Browse repository at this point
Copy the full SHA 4bcd110View commit details -
Clean up tests for the existing brace_style options
- Move several tests not involving brace positions out of the brace position testing section, and eliminate duplication - Ensure parallel tests exist for all 3 brace styles - Add comments to clarify the sections are testing brace positions - Move copy-pasted, commented out test up to opening brace position tests comment, and add note to update tests correctly if the case is ever supported.
Configuration menu - View commit details
-
Copy full SHA for 163bc23 - Browse repository at this point
Copy the full SHA 163bc23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 140b18e - Browse repository at this point
Copy the full SHA 140b18eView commit details -
Each removed test was an exact duplicate of the test 5 lines before it
Configuration menu - View commit details
-
Copy full SHA for 7d0a19c - Browse repository at this point
Copy the full SHA 7d0a19cView commit details -
Remove bt_braces function that is never used
looks very similar to what I plan to implement in my next commit
Configuration menu - View commit details
-
Copy full SHA for e553a8b - Browse repository at this point
Copy the full SHA e553a8bView commit details -
Refactor brace position tests to eliminate copy-pasting
Abstracts out the opening and closing whitespace before opening braces and before closing braces, respectively, so that the tests are all written in one place instead of 4 huge blocks, 1 for each brace style.
Configuration menu - View commit details
-
Copy full SHA for 4524383 - Browse repository at this point
Copy the full SHA 4524383View commit details
Commits on Oct 6, 2014
-
Preserve opening brace position other than whitespace / indentation i…
…n Python version
Configuration menu - View commit details
-
Copy full SHA for 0fa529f - Browse repository at this point
Copy the full SHA 0fa529fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f97d0d - Browse repository at this point
Copy the full SHA 8f97d0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 670f44c - Browse repository at this point
Copy the full SHA 670f44cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.