Suggestions for some corrections/improvements #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not 100% sure that the changes are what you want, I discuss them here a bit:
https://www.beeflang.org/docs/language-guide/memory/
Variant: link reflection doesn't work
points to https://www.beeflang.org/docs/language-guide/memory/reflection.html
but this gives: Page not found
Link should probably be: https://www.beeflang.org/docs/language-guide/reflection/
The original int newVal = GetMinusOne(i);
gives a compilation error: ERROR: Unable to implicitly cast 'uint' to 'int'
which is solved by changing int to uint
https://www.beeflang.org/docs/language-guide/operators/
/* Binary + operator */
public static Vector2 operator+(Vector2 lhs, Vector2 rhs)
{
return .(lhs.x, rhs.y);
}
I don't understand how this could mean a + operation of 2 vectors.
I would expect: return .(lhs.x + rhs.x, lhs.y + rhs.y);
https://www.beeflang.org/docs/language-guide/typerefs/
int intVal = (.)floatVal); <-- minor improvement adding int and ;
https://www.beeflang.org/docs/corlib/
this-party <-- probably here also third-party was meant.
Thanks for the review and keep up the brilliant work!