-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reworked systems admin page #405
reworked systems admin page #405
Conversation
Two general observations from trying it out:
That older style one stands out a lot more to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish there were tests added for the new files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good otherwise to me, ops check looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some observations from testing:
|
Closes #392, #393, #307
Reworked the systems admin page to look and feel like the old UI and changed the
UnassociatedRunners
to list each runner under a path rather than showing just the path.Also on the request view page I changed the import for
RemakeRequestButton
so the spacing around thenavbar
is the same as the other pages.