Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] product_main_supplier #519

Merged
merged 15 commits into from
Sep 7, 2023

Conversation

victor-champonnois and others added 14 commits August 2, 2023 14:04
into:
- product_main_supplier
- sale_suggested_price
- sale_adapt_price_wizard

[REF] split beesdoo_product -> product_main_supplier

[FIX] sale_suggested_price dep on product_main_supplier

[ADD] module sale_edit_price_wizard

[REF] rename sale_edit_price_wizard ->  sale_adapt_price_wizard

[REF] move rounding_method to sale_suggested_price

[REF] refactor following PR 320

[REF] search product_code -> product_main_seller

[FIX] bug adapt_sales_price

[IMP] use float_compare to compare prices

[REF] move list_price_write_date to sale_adapt_price_wizard

[FIX] beesdoo_product: main_seller_id search

[FIX] run precommit

fix
Copy link
Collaborator

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one improvement

product_main_supplier/models/product_template.py Outdated Show resolved Hide resolved
Co-authored-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@codecov-commenter
Copy link

Codecov Report

Merging #519 (aeabc8b) into 16.0 (5a5457c) will increase coverage by 1.55%.
The diff coverage is 97.26%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             16.0     #519      +/-   ##
==========================================
+ Coverage   64.17%   65.72%   +1.55%     
==========================================
  Files          34       41       +7     
  Lines        1485     1558      +73     
  Branches      207      214       +7     
==========================================
+ Hits          953     1024      +71     
- Misses        491      492       +1     
- Partials       41       42       +1     
Files Changed Coverage Δ
...oduct_main_supplier/models/product_supplierinfo.py 81.81% <81.81%> (ø)
product_main_supplier/__init__.py 100.00% <100.00%> (ø)
product_main_supplier/models/__init__.py 100.00% <100.00%> (ø)
product_main_supplier/models/product_template.py 100.00% <100.00%> (ø)
product_main_supplier/tests/__init__.py 100.00% <100.00%> (ø)
product_main_supplier/tests/test_main_seller_id.py 100.00% <100.00%> (ø)
...lier/tests/test_search_main_seller_product_code.py 100.00% <100.00%> (ø)

@victor-champonnois
Copy link
Member Author

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-519-by-victor-champonnois-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit 0b1d640 into 16.0 Sep 7, 2023
2 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 98de475. Thanks a lot for contributing to beescoop. ❤️

@github-grap-bot github-grap-bot deleted the 16.0-mig-product_main_supplier branch September 7, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants