Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add space-padding to missing tracks dialog #2962

Merged
merged 6 commits into from
Jun 20, 2018
Merged

Add space-padding to missing tracks dialog #2962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
399fdc9
add space-padding to missing tracks dialog
jams2 Jun 19, 2018
15b53f2
update changelog.rst
jams2 Jun 19, 2018
e085368
fix style
jams2 Jun 19, 2018
df2172b
add variable width justification to missing tracks dialog
jams2 Jun 20, 2018
b6947dd
change ui.commands.show_change to align missing tracks by length of l…
jams2 Jun 20, 2018
68590e1
remove unnecessary list comp, add descriptive variable names
jams2 Jun 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions beets/ui/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,15 +378,22 @@ def format_index(track_info):
len(match.info.tracks),
len(match.extra_tracks) / len(match.info.tracks)
))
pad_width = max(len(track_info.title) for track_info in
match.extra_tracks)
for track_info in match.extra_tracks:
line = u' ! %s (#%s)' % (track_info.title, format_index(track_info))
line = u' ! {0: <{width}} (#{1: >2})'.format(track_info.title,
format_index(track_info),
width=pad_width)
if track_info.length:
line += u' (%s)' % ui.human_seconds_short(track_info.length)
print_(ui.colorize('text_warning', line))
if match.extra_items:
print_(u'Unmatched tracks ({0}):'.format(len(match.extra_items)))
pad_width = max(len(item.title) for item in match.extra_items)
for item in match.extra_items:
line = u' ! %s (#%s)' % (item.title, format_index(item))
line = u' ! {0: <{width}} (#{1: >2})'.format(item.title,
format_index(item),
width=pad_width)
if item.length:
line += u' (%s)' % ui.human_seconds_short(item.length)
print_(ui.colorize('text_warning', line))
Expand Down
2 changes: 2 additions & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ New features:
and Winamp.
Thanks to :user:`mz2212`.
:bug:`2944`
* Added whitespace padding to missing tracks dialog to improve readability.
:user:`jams2`

Fixes:

Expand Down