Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline album attributes modification behaviour and allow override via CLI #4823

Merged
merged 10 commits into from
Aug 23, 2023
Merged

Streamline album attributes modification behaviour and allow override via CLI #4823

merged 10 commits into from
Aug 23, 2023

Commits on Aug 23, 2023

  1. Propagate album flex attr mods to items 

    It seems that _deleting_ flex attrs from an album already propagate to items.
Now also _modifications_ of album flex attrs propagate to items.
    @JOJ0
    JOJ0 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    56c1ff8 View commit details
    Browse the repository at this point in the history

  2. Option to override album mods propagation to items 

    Adds a cli option to the modify command that prevents inheriting `modify -a`
changes to album-tracks.
    @JOJ0
    JOJ0 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3587067 View commit details
    Browse the repository at this point in the history

  3. Fix failing test_a_album*_edit_apply tests by 

    excluding 'id' fields when storing within the Album model.
    @JOJ0
    JOJ0 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3c7f122 View commit details
    Browse the repository at this point in the history

  4. Fix test_albuminfo_change_artist_does_not_change_items 

    by adding (inherit=True) to fit with the new behaviour of the store() method
and add a second test that checks the opposite.
    @JOJ0
    JOJ0 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    94d0041 View commit details
    Browse the repository at this point in the history

  5. Fix ipfs plugin and test_ipfs 

    by using store(inherit=False) for the creation of a new "ipfs album" as well as
when test_ipfs creates album+items to compare with.
Or put differently: Make ipfs and test_ipfs keep the old store() behaviour for
which the plugin initially was built for.
    @JOJ0
    JOJ0 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    8d835b8 View commit details
    Browse the repository at this point in the history

  6. Add changelog for beetbox#4823

    @JOJ0
    JOJ0 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    7b49b86 View commit details
    Browse the repository at this point in the history

  7. Add docs for mod -a --noinherit option 

    and further clarify `mod -a` docs:
Even though e39dcfc and the linked discussion
already does a very good job on clarifying what is actually happening when `mod
-a` is issued, this commit adds further details about the difference between
the album query and what is actually modified.
    @JOJ0
    JOJ0 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    31cd0ec View commit details
    Browse the repository at this point in the history

  8. Clarify Album.store() docstring and comments, 

    explaining the inherit flag, fixed/flex attrs and the strict exclusion
of the id field.
    @JOJ0
    JOJ0 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ad31999 View commit details
    Browse the repository at this point in the history

  9. Fixes in docs for beetbox#4823 

    as suggested by @sampsyo.

Co-authored-by: Adrian Sampson <adrian@radbox.org>
    @JOJ0 @sampsyo
    JOJ0 and sampsyo committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    9616afd View commit details
    Browse the repository at this point in the history

  10. Refactor Album.store for code readability

    @JOJ0
    JOJ0 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d7b7d60 View commit details
    Browse the repository at this point in the history