Fixed check for pseudo-release. #4833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'status' field is potentially null, and in this case the dictionary key it is not returned by the API. Using get will return null in this case. Tested locally and this solves the issue!
|
Thanks!! Looks like this was introduced in #4714. @TypicalFence, could you please take a look? It would be really useful to add a test here that reflects all the kinds of data that can might be missing to make sure we don't make the same mistake again. |
sampsyo
approved these changes
Jun 29, 2023
|
Indeed; thanks for the heads up, @TypicalFence! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'status' field is potentially null, and in this case the dictionary key is not returned by the API. Using get will return null in this case. Tested locally and this solves the issue!
Description
Fixes #4832.