Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaygain: Assorted refactoring #4851

Merged
merged 6 commits into from
Jul 23, 2023
Merged

replaygain: Assorted refactoring #4851

merged 6 commits into from
Jul 23, 2023

Commits on Jul 22, 2023

  1. replaygain: avoid hasattr in favor of None values 

    to check for an optional ThreadPool. Seems more idiomatic and readable.
    @wisp3rwind
    wisp3rwind committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    7ec7a0d View commit details
    Browse the repository at this point in the history

  2. replaygain: log album name for album tasks 

    doesn't seem to be very useful to log the _list of items_ here
    @wisp3rwind
    wisp3rwind committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    545ed6f View commit details
    Browse the repository at this point in the history

  3. replaygain: in ffmpeg backend, analyse items upfront, then summarize... 

    ...album gains. This is in preparation for parallelizing the track
analysis, and computing the album values in the plugin's "main thread"
once all items are done.
    @wisp3rwind
    wisp3rwind committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    76f6c86 View commit details
    Browse the repository at this point in the history

  4. replaygain: in ffmpeg backend refactor album gain calculation 

    now that we have the `track_results` upfront, some simplifications are
possible
    @wisp3rwind
    wisp3rwind committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    fa37085 View commit details
    Browse the repository at this point in the history

  5. replaygain: in Gst backend, pass paths instead of items around 

    This is a preparation for moving the Gst calculation to multiprocessing
worker threads. Passing only the file paths to the worker threads instead of
synchronizing the entire `Item`s (i.e. minimizing the data that is
shared between the processes) hopefully helps to prevent any issues with
this approach.
    @wisp3rwind
    wisp3rwind committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    b8be2af View commit details
    Browse the repository at this point in the history

  6. replaygain: apply review feedback: fixup previous refactor, improve t… 

    …ests

by adding files which are not completely silent, thus hitting a different
code path in some calculations

The sample files were generated using
> sox -n whitenoise.flac synth 00:00:02 whitenoise
> ffmpeg -i whitenoise.flac whitenoise.opus
> ffmpeg -i whitenoise.flac whitenoise.mp3
    @wisp3rwind
    wisp3rwind committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    3965858 View commit details
    Browse the repository at this point in the history