Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing: Wrap up dbcore #4858

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Conversation

wisp3rwind
Copy link
Member

Finally, mypy is happy about dbcore 🎉

@wisp3rwind wisp3rwind force-pushed the dbcore_typing_4 branch 3 times, most recently from 33287a5 to 7a8821f Compare July 22, 2023 12:11
Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

This all looks great!! Amazing work seeing this through.

beets/dbcore/db.py Show resolved Hide resolved
beets/dbcore/db.py Show resolved Hide resolved
beets/dbcore/db.py Show resolved Hide resolved
beets/dbcore/db.py Show resolved Hide resolved
@wisp3rwind wisp3rwind merged commit ab3e2a9 into beetbox:master Jul 26, 2023
14 checks passed
@wisp3rwind wisp3rwind deleted the dbcore_typing_4 branch July 26, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants