Optional more verbose duplicates prompt #4866
Conversation
beets/ui/commands.py
Outdated
| if not task.is_album: | ||
| print(f" {duplicate}") | ||
| else: | ||
| for dup in duplicate.items(): | ||
| print(f" {dup}") |
There was a problem hiding this comment.
This might be slightly easier to read if it were reversed! (That is, start with if task.is_album:.)
There was a problem hiding this comment.
Hahaha, I had it the other way round and thought: That looks badly readable and switched it around. But actually I agree with you, starting with a negated condition when there is an else branch anyway, is often confusing. I'll change it back! :-)
JOJ0
force-pushed
the
duplicates_verbose
branch
from
449e534
to
d78ddb2
Compare
JOJ0
force-pushed
the
duplicates_verbose
branch
from
d78ddb2
to
7cc2943
Compare
|
Thanks @JOJ0 It would be nice to get this related PR to handle upgrades merged soon. |
JOJ0
force-pushed
the
duplicates_verbose
branch
from
7cc2943
to
b66a4c2
Compare
JOJ0
force-pushed
the
duplicates_verbose
branch
from
b66a4c2
to
5afd2a6
Compare
|
Alright, I'm quite happy with this feature now and it's ready for a final review. Some nitpicking on my docs-wording and format might be good! Thanks in advance! Hmm, I left out the fact that also singleton imports would now present a more verbose prompt in my docs text. Is that bad? Should I add it? |
JOJ0
force-pushed
the
duplicates_verbose
branch
from
5afd2a6
to
ef5c4de
Compare
Description
A new config option allows to enable a more detailed view when a duplicate is detected during import of an album or singleton.
importconfig option:To Do
Tests.