Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes TypeError in the Discogs plugin #5415

Merged
merged 11 commits into from
Sep 19, 2024
Merged

Fixes TypeError in the Discogs plugin #5415

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f4a7ccd
Update discogs.py
amogus07 Sep 10, 2024
cf6c089
happy now?
amogus07 Sep 10, 2024
59b8d72
Use list() instead of str()
amogus07 Sep 12, 2024
315c902
Merge branch 'beetbox:master' into fix-discogs-typeerror
amogus07 Sep 17, 2024
393ca44
discogs: prevent TypeError
amogus07 Sep 18, 2024
17f7ed5
changelog: add discogs TypeError fix
amogus07 Sep 18, 2024
4f98659
Merge branch 'beetbox:master' into fix-discogs-typeerror
amogus07 Sep 18, 2024
854e6fc
changelog: minor change for better consistency
amogus07 Sep 18, 2024
abc7a76
update changelog
amogus07 Sep 19, 2024
e1a5088
should have checked
amogus07 Sep 19, 2024
fe642a7
Isolate parsing formats into a separate method and test it
snejus Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion beetsplug/discogs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,9 @@ def get_album_info(self, result):
albumtype = media = label = catalogno = labelid = None
if result.data.get("formats"):
albumtype = (
", ".join(result.data["formats"][0].get("descriptions", []))
", ".join(
amogus07 marked this conversation as resolved.
Show resolved Hide resolved
str(result.data["formats"][0].get("descriptions", []))
)
snejus marked this conversation as resolved.
Show resolved Hide resolved
or None
)
media = result.data["formats"][0]["name"]
Expand Down