Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml: don't install docs et al into the wheel #5552

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ArsenArsen
Copy link
Contributor

Description

wheels are directly unpacked into site-packages, so this means likely conflict with other packages

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

if a changelog entry is needed, I am happy to add one. tests/docs seem not applicable (as this is purely a packaging issue)

wheels are directly unpacked into site-packages, so this means likely
conflict with other packages
@snejus
Copy link
Member

snejus commented Dec 19, 2024

image

I should have not trusted poetry docs which say that format parameter defaults to sdist 🤡

Copy link
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks for this <3

@snejus snejus merged commit 994f9b8 into beetbox:master Dec 19, 2024
11 checks passed
@ArsenArsen
Copy link
Contributor Author

image

I should have not trusted poetry docs which say that format parameter defaults to sdist 🤡

heh, they seem to have changed it between versions.. which means one can't rely on it right now

thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants