Clarify where to package Android from #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieFero
force-pushed
the
clarify-where-to-package-from
branch
from
34eed0f
to
14577d9
Compare
mhsmith
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a sentence to the Android packaging documentation to clarify that you should run these commands from within the directory that has the
pyproject.tomlfile.While working on #1212, @mas192 ran into some trouble testing Android builds because the docs didn't say whether there was a way to run the build commands from another directory (like by specifying where the pyproject.toml is). It seems like there's not! This PR does not actually resolve #1212 , which will be addressed separately, but does address the confusion we encountered during testing.
PR Checklist: