Make API support table circles a more consistent size #1802

mhsmith · 2023-03-04T15:31:01Z

The fonts in the Furo style sheet are:

-apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-serif,Apple Color Emoji,Segoe UI Emoji;

On macOS, this resolves to the system font SF, where the black and white circles are the same size, and fairly large. But on Windows it uses Segoe UI, where the black circle is much smaller than the white one.

This PR makes the tables use fonts whose circles are equally-sized, and fit in well with the specified font size.

I considered using other Unicode circles instead, but none of them worked well enough:

The "medium" circles appeared as emojis by default, which stopped them responding to dark mode. There's a variation character which is supposed to switch them back to text mode, but it only worked on Windows, not macOS.
The "large" circles were not supported by SF, Arial or Lucida Grande, causing the browser to fall back on other fonts with inconsistent alignment.

Test document for future reference:

<!DOCTYPE html>
<html>
<head><title>Circle test</title></head>
<body>
<p>Plain: &#x25cb; &#x25cf;</p>
<p>Medium: &#x26aa; &#x26ab;</p>
<p>Medium text: &#x26aa;&#xfe0e; &#x26ab;&#xfe0e;</p>
<p>Large: &#x25ef; &#x2b24;</p>
</body>
</html>

PR Checklist:

All new features have been tested
All new features have been documented
I have read the CONTRIBUTING.md file
I will abide by the code of conduct

mhsmith · 2023-03-04T15:42:06Z

Also fixed the admonition in pack.rst which was added in #1786, but was being omitted by the readthedocs build because admonition requires a title.

And updated the readthedocs configuration to make warnings fatal, so problems like this will not be silent in the future.

freakboy3742

Looks good to me - and the alt-text/role handling is a nice touch, too.

mhsmith added 2 commits March 4, 2023 15:13

Make API support table circles a more consistent size

f6407d4

Change admonition to note

5b406bd

mhsmith requested a review from freakboy3742 March 4, 2023 16:15

freakboy3742 approved these changes Mar 5, 2023

View reviewed changes

freakboy3742 merged commit 26ed94e into beeware:main Mar 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make API support table circles a more consistent size #1802

Make API support table circles a more consistent size #1802

mhsmith commented Mar 4, 2023

mhsmith commented Mar 4, 2023

freakboy3742 left a comment

Make API support table circles a more consistent size #1802

Make API support table circles a more consistent size #1802

Conversation

mhsmith commented Mar 4, 2023

PR Checklist:

mhsmith commented Mar 4, 2023

freakboy3742 left a comment

Choose a reason for hiding this comment